Bug 26891 - Remove unused code in SVGTransformList and SVGTransformDistance
Summary: Remove unused code in SVGTransformList and SVGTransformDistance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-01 11:34 PDT by David Levin
Modified: 2009-07-01 14:07 PDT (History)
1 user (show)

See Also:

Attachments
patch (4.61 KB, patch)
2009-07-01 11:38 PDT, David Levin 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-07-01 11:34:40 PDT 
This code had the potential to use an uninitialized m_cx, m_cy.  Since it is unused, I'm simply removing it.
Comment 1 David Levin 2009-07-01 11:38:30 PDT 
Created attachment 32131 [details]
patch
Comment 2 Eric Seidel (no email) 2009-07-01 13:36:12 PDT 
Comment on attachment 32131 [details]
patch

Why not fix the default constructor?  I support removing the dead code though.

Wow, this code is old.  This was from yet-another attempt at animation by yours truly... forever ago.  I think you shoudl fix the default constructor to zero everything instead of changing the callsites.
Comment 3 David Levin 2009-07-01 14:07:39 PDT 
Committed as http://trac.webkit.org/changeset/45448

I did a slight modification to change the default constructor as Eric suggested.