WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26891
Remove unused code in SVGTransformList and SVGTransformDistance
https://bugs.webkit.org/show_bug.cgi?id=26891
Summary
Remove unused code in SVGTransformList and SVGTransformDistance
David Levin
Reported
2009-07-01 11:34:40 PDT
This code had the potential to use an uninitialized m_cx, m_cy. Since it is unused, I'm simply removing it.
Attachments
patch
(4.61 KB, patch)
2009-07-01 11:38 PDT
,
David Levin
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2009-07-01 11:38:30 PDT
Created
attachment 32131
[details]
patch
Eric Seidel (no email)
Comment 2
2009-07-01 13:36:12 PDT
Comment on
attachment 32131
[details]
patch Why not fix the default constructor? I support removing the dead code though. Wow, this code is old. This was from yet-another attempt at animation by yours truly... forever ago. I think you shoudl fix the default constructor to zero everything instead of changing the callsites.
David Levin
Comment 3
2009-07-01 14:07:39 PDT
Committed as
http://trac.webkit.org/changeset/45448
I did a slight modification to change the default constructor as Eric suggested.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug