ssia
Created attachment 469756 [details] Patch
Created attachment 469757 [details] Patch
Created attachment 469759 [details] [fast-cq]Patch
Committed 274252@main (56ef8327a9a9): <https://commits.webkit.org/274252@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469759 [details].
<rdar://problem/122502444>
Broke the watchOS build, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=268964
Created attachment 469771 [details] [fast-cq]Patch
Committed 274300@main (4bd4d4f8b539): <https://commits.webkit.org/274300@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469771 [details].
Comment on attachment 469771 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=469771&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cppSource/WebCore/layout/formattingContexts/flex/FlexFormattingState.cpp:37 > + : m_flexFormattingContext(flexFormattingContext) Will the m_flexFormattingContext variable be used later? It is unused right now. It triggers build errors on Clang linux debug builds, with -Werror,-Wunused-private-field
(In reply to Olivier Blin from comment #9) > Comment on attachment 469771 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=469771&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cppSource/WebCore/layout/formattingContexts/flex/FlexFormattingState.cpp:37 > > + : m_flexFormattingContext(flexFormattingContext) > > Will the m_flexFormattingContext variable be used later? > It is unused right now. > > It triggers build errors on Clang linux debug builds, with > -Werror,-Wunused-private-field Yeah, it is going to be used soon but also if it blocks you in any way, feel free to remove it (or let me know if you want me to remove it). Thanks!
(In reply to zalan from comment #10) > (In reply to Olivier Blin from comment #9) > > Will the m_flexFormattingContext variable be used later? > > It is unused right now. > > > > It triggers build errors on Clang linux debug builds, with > > -Werror,-Wunused-private-field > Yeah, it is going to be used soon but also if it blocks you in any way, feel > free to remove it (or let me know if you want me to remove it). Thanks! No, that's ok if it is going to be used later. Thanks for the heads-up!