Bug 268825 – Apply SVG paint-order to text-decorations

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across another potential merge:

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/72eecba077f756ef4ed254541ff37dcb9baec05a

Test Case: https://jsfiddle.net/w1z3vo6u/show

^ Chrome Canary 123 and Firefox Nightly 124 match but Chrome has bit thicker underlines etc.

WebKit Source: https://searchfox.org/wubkat/rev/5266b069f715d2051da7f1fc8def26d5dcd5e03c/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp#537

___

Following compiles and fix it:

    for (auto type : RenderStyle::paintTypesForPaintOrder(renderer().style().paintOrder())) {
        switch (type) {
        case PaintType::Fill:
            if (svgDecorationStyle.hasFill()) {
                setPaintingResourceMode(RenderSVGResourceMode::ApplyToFill);
                paintDecorationWithStyle(context, decoration, fragment, decorationRenderer);
            }
            break;
        case PaintType::Stroke:
            if (decorationStyle.hasVisibleStroke()) {
                setPaintingResourceMode(RenderSVGResourceMode::ApplyToStroke);
                paintDecorationWithStyle(context, decoration, fragment, decorationRenderer);
            }
            break;
        case PaintType::Markers:
            break;
        default:
            ASSERT_NOT_REACHED();
        }
    }

___

This fixes it.

Just raising so we can do PR.

Thanks!

[Ahmad Saleem]

Created attachment 469751 [details]
STP187 vs Patched

[Radar WebKit Bug Importer]

<rdar://problem/122574354>

[EWS]

Committed 274814@main (9ce832dcb0d3): <https://commits.webkit.org/274814@main>

Reviewed commits have been landed. Closing PR #23960 and removing active labels.