RESOLVED FIXED 268796
[MSE] Remove HTMLMediaElement access from MediaSource 
https://bugs.webkit.org/show_bug.cgi?id=268796
Summary [MSE] Remove HTMLMediaElement access from MediaSource
Jean-Yves Avenard [:jya]
Reported 2024-02-05 19:36:05 PST
subtask of bug 264134 Currently the MediaSource::monitorSourceBuffer requires the mediaElement's currentTime. But to do so, it directly access the HTMLMediaElement::currentMediaTime [1] As the MediaSource may not be running in the same thread in the future, it may not be safe for the MediaSource to directly access the MediaElement. An alternative would be to access the MediaPlayer instead, which has a more up to date value of the current time. [1] https://searchfox.org/wubkat/rev/5266b069f715d2051da7f1fc8def26d5dcd5e03c/Source/WebCore/Modules/mediasource/MediaSource.cpp#182-187
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-05 19:36:24 PST
<rdar://problem/122359957>
Jean-Yves Avenard [:jya]
Comment 2 2024-02-09 06:08:51 PST
Pull request: https://github.com/WebKit/WebKit/pull/24142
EWS
Comment 3 2024-02-11 03:03:57 PST
Committed 274442@main (b0908a7024e1): <https://commits.webkit.org/274442@main> Reviewed commits have been landed. Closing PR #24142 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.