NEW268774
Re-enable tests that check clientDataJSON for TestRunner 
https://bugs.webkit.org/show_bug.cgi?id=268774
Summary Re-enable tests that check clientDataJSON for TestRunner
pascoe@apple.com
Reported 2024-02-05 12:55:09 PST
These don't work right now because we don't mock calls to AuthenticationServicesAgent. We should do that to improve our web authn-related layout tests.
Attachments
Add attachment proposed patch, testcase, etc.
pascoe@apple.com
Comment 1 2024-02-05 16:22:30 PST
In the short term I have set clientDataJSON manually when we are running in tests, which will allow us to reenable - http/wpt/webauthn/idl.https.html - http/wpt/webauthn/public-key-credential-create-success-ccid.https.html - http/wpt/webauthn/public-key-credential-create-success-local.https.html - http/wpt/webauthn/public-key-credential-create-success-u2f.https.html - http/wpt/webauthn/public-key-credential-get-success-ccid.https.html - http/wpt/webauthn/public-key-credential-get-success-hid.https.html In the longer term I'm going to sit down and write a mock implementation of our AS... APIs to make the tests run in a configuration closer to reality.
Radar WebKit Bug Importer
Comment 2 2024-02-05 16:22:52 PST
<rdar://problem/122350233>
pascoe@apple.com
Comment 3 2024-02-06 13:13:54 PST
Pull request: https://github.com/WebKit/WebKit/pull/23950
EWS
Comment 4 2024-02-06 13:22:28 PST
Test gardening commit 274169@main (a33387dca368): <https://commits.webkit.org/274169@main> Reviewed commits have been landed. Closing PR #23950 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.