Bug 26877 - [GTK] DRT fixes to pass new plugin test
: [GTK] DRT fixes to pass new plugin test
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-30 23:27 PDT by Xan Lopez
Modified: 2009-06-30 23:51 PDT (History)
0 users

See Also:


Attachments
logsrc.patch (2.32 KB, patch)
2009-06-30 23:30 PDT, Xan Lopez
jmalonzo: review+
Details | Formatted Diff | Diff
pluginlog.patch (5.03 KB, patch)
2009-06-30 23:31 PDT, Xan Lopez
jmalonzo: review+
Details | Formatted Diff | Diff
compilerwarning.patch (3.24 KB, patch)
2009-06-30 23:39 PDT, Xan Lopez
jmalonzo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-06-30 23:27:07 PDT
bug #15457 requires a small modification in DRT in order to pass its new test. Done in attached patch.
Comment 1 Xan Lopez 2009-06-30 23:30:42 PDT
Created attachment 32112 [details]
logsrc.patch

Fix DRT.
Comment 2 Xan Lopez 2009-06-30 23:31:06 PDT
Created attachment 32113 [details]
pluginlog.patch

Small cleanup.
Comment 3 Jan Alonzo 2009-06-30 23:35:19 PDT
Comment on attachment 32112 [details]
logsrc.patch

Ok. r=me.
Comment 4 Jan Alonzo 2009-06-30 23:36:37 PDT
Comment on attachment 32113 [details]
pluginlog.patch

Fine. r=me.
Comment 5 Xan Lopez 2009-06-30 23:39:06 PDT
Created attachment 32115 [details]
compilerwarning.patch

Fix compiler warnings.
Comment 6 Jan Alonzo 2009-06-30 23:43:10 PDT
Comment on attachment 32115 [details]
compilerwarning.patch

>      switch (variable) {
>          case NPPVpluginNameString:
> -            *((char **)value) = "WebKit Test PlugIn";
> +            *((char **)value) = (char*)"WebKit Test PlugIn";

Please change these to static_casts before commit. r=me.
Comment 7 Xan Lopez 2009-06-30 23:50:19 PDT
(In reply to comment #6)
> (From update of attachment 32115 [details] [review])
> >      switch (variable) {
> >          case NPPVpluginNameString:
> > -            *((char **)value) = "WebKit Test PlugIn";
> > +            *((char **)value) = (char*)"WebKit Test PlugIn";
> 
> Please change these to static_casts before commit. r=me.
> 

static_cost won't work in this case. I'll use const_cast.
Comment 8 Xan Lopez 2009-06-30 23:51:46 PDT
All patches landed as r45429, r45430 and r45431, closing.