Bug 26877 - [GTK] DRT fixes to pass new plugin test
: [GTK] DRT fixes to pass new plugin test
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-06-30 23:27 PST by
Modified: 2009-06-30 23:51 PST (History)


Attachments
logsrc.patch (2.32 KB, patch)
2009-06-30 23:30 PST, Xan Lopez
jmalonzo: review+
Review Patch | Details | Formatted Diff | Diff
pluginlog.patch (5.03 KB, patch)
2009-06-30 23:31 PST, Xan Lopez
jmalonzo: review+
Review Patch | Details | Formatted Diff | Diff
compilerwarning.patch (3.24 KB, patch)
2009-06-30 23:39 PST, Xan Lopez
jmalonzo: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-06-30 23:27:07 PST
bug #15457 requires a small modification in DRT in order to pass its new test. Done in attached patch.
------- Comment #1 From 2009-06-30 23:30:42 PST -------
Created an attachment (id=32112) [details]
logsrc.patch

Fix DRT.
------- Comment #2 From 2009-06-30 23:31:06 PST -------
Created an attachment (id=32113) [details]
pluginlog.patch

Small cleanup.
------- Comment #3 From 2009-06-30 23:35:19 PST -------
(From update of attachment 32112 [details])
Ok. r=me.
------- Comment #4 From 2009-06-30 23:36:37 PST -------
(From update of attachment 32113 [details])
Fine. r=me.
------- Comment #5 From 2009-06-30 23:39:06 PST -------
Created an attachment (id=32115) [details]
compilerwarning.patch

Fix compiler warnings.
------- Comment #6 From 2009-06-30 23:43:10 PST -------
(From update of attachment 32115 [details])
>      switch (variable) {
>          case NPPVpluginNameString:
> -            *((char **)value) = "WebKit Test PlugIn";
> +            *((char **)value) = (char*)"WebKit Test PlugIn";

Please change these to static_casts before commit. r=me.
------- Comment #7 From 2009-06-30 23:50:19 PST -------
(In reply to comment #6)
> (From update of attachment 32115 [details] [review])
> >      switch (variable) {
> >          case NPPVpluginNameString:
> > -            *((char **)value) = "WebKit Test PlugIn";
> > +            *((char **)value) = (char*)"WebKit Test PlugIn";
> 
> Please change these to static_casts before commit. r=me.
> 

static_cost won't work in this case. I'll use const_cast.
------- Comment #8 From 2009-06-30 23:51:46 PST -------
All patches landed as r45429, r45430 and r45431, closing.