WebCore/platform/text/TextCodecICU.cpp defines 16KB-32KB local variables. They are too large for the stack.
Created attachment 32109 [details] Proposed patch
In what sense are they too large for the stack? Rather than manually calling delete it would be preferable to use an OwnPtr to make the code more robust against future modifications.
(In reply to comment #2) > In what sense are they too large for the stack? It's almost subjective. Chromium doesn't have any problems about this "large" buffers. However Coverity Prevent tool detected it as defects and they might make problems on other platforms. If you think we don't need to fix them, it's ok to reject the patch. > Rather than manually calling delete it would be preferable to use an OwnPtr to > make the code more robust against future modifications. Dows OwnPtr work for arrays?
Comment on attachment 32109 [details] Proposed patch The whole point here is to use a buffer size that fits on the stack to avoid the overhead of heap allocation. If some platforms need the conversion chunk to be smaller, it seems best to me to simply make ConversionBufferSize a smaller number for those platforms.
(In reply to comment #4) > it seems best to me to simply make ConversionBufferSize a smaller > number for those platforms. That's reasonable. Ok, I withdraw this patch and close this bug.
Comment on attachment 32109 [details] Proposed patch Clearing review flag and marking obsolete, since the patch is withdrawn.