RESOLVED FIXED268645
WebExtensionContext::handleContentRuleListNotificationForTab activeTab permission check is wrong 
https://bugs.webkit.org/show_bug.cgi?id=268645
Summary WebExtensionContext::handleContentRuleListNotificationForTab activeTab permis...
Timothy Hatcher
Reported 2024-02-02 11:30:59 PST
We should do `hasPermission(url, &tab)` instead of `hasPermission(_WKWebExtensionPermissionActiveTab)`, which will properly check for all host permission cases, including `activeTab` temp host permissions. I'm not even sure the `hasPermission(_WKWebExtensionPermissionDeclarativeNetRequest)` check is needed, since we already check `_WKWebExtensionPermissionDeclarativeNetRequestFeedback`.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-02 11:31:08 PST
<rdar://problem/122197589>
Radar WebKit Bug Importer
Comment 2 2024-02-02 11:35:53 PST
<rdar://problem/122197797>
Timothy Hatcher
Comment 3 2024-02-02 11:36:10 PST
<rdar://problem/122197589>
Brian Weinstein
Comment 4 2024-02-02 15:59:34 PST
Pull request: https://github.com/WebKit/WebKit/pull/23788
EWS
Comment 5 2024-02-02 18:18:50 PST
Committed 274030@main (63b67f18d2d2): <https://commits.webkit.org/274030@main> Reviewed commits have been landed. Closing PR #23788 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.