RESOLVED FIXED 268633
NetworkConnectionToWebProcess's MESSAGE_CHECK should just be calling into MESSAGE_CHECK_BASE 
https://bugs.webkit.org/show_bug.cgi?id=268633
Summary NetworkConnectionToWebProcess's MESSAGE_CHECK should just be calling into MES...
Gavin
Reported 2024-02-02 09:40:25 PST
NetworkConnectionToWebProcess's MESSAGE_CHECK should just be calling into MESSAGE_CHECK_BASE. We want MESSAGE_CHECK's to kill WebContent and stop processing the message when m_ignoreInvalidMessageForTesting==false and stop processing the message when m_ignoreInvalidMessageForTesting==true. Currently many connections implement their own version of MESSAGE_CHECK which leads to inconsistent behaviour. By having NetworkConnectionToWebProcess's MESSAGE_CHECK call into MESSAGE_CHECK_BASE, we should markCurrentlyDispatchedMessageAsInvalid which should then dispatch didReceiveInvalidMessage to the connection client when m_ignoreInvalidMessageForTesting is false. didReceiveInvalidMessage can then terminate the WebContent process for us.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-02 09:43:04 PST
<rdar://problem/122191138>
Gavin
Comment 2 2024-02-02 09:45:01 PST
Pull request: https://github.com/WebKit/WebKit/pull/23752
EWS
Comment 3 2024-02-05 11:15:19 PST
Committed 274106@main (67bfc13f4de7): <https://commits.webkit.org/274106@main> Reviewed commits have been landed. Closing PR #23752 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.