Bug 26859 - StorageNamespace.cpp build issue
Summary: StorageNamespace.cpp build issue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-30 13:56 PDT by Maxime Simon
Modified: 2009-06-30 19:16 PDT (History)
0 users

See Also:


Attachments
Patch for this bug (1.58 KB, patch)
2009-06-30 14:07 PDT, Maxime Simon
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Simon 2009-06-30 13:56:16 PDT
In WebCore/storage/StorageNamespace.cpp,
namespace WebCore is closed after the #endif (which starts before the namespace).
So if #if ENABLE(DOM_STORAGE) is true there is no problem, but if not it causes the build to fail.
Comment 1 Maxime Simon 2009-06-30 14:07:15 PDT
Created attachment 32093 [details]
Patch for this bug
Comment 2 Eric Seidel (no email) 2009-06-30 14:42:46 PDT
Comment on attachment 32093 [details]
Patch for this bug

LGTM.
Comment 3 Jan Alonzo 2009-06-30 19:16:26 PDT
(In reply to comment #2)
> (From update of attachment 32093 [details] [review])
> LGTM.
> 

Landed in r45413.