Bug 26858 - Add column reflection of dcol elements into datagrid's columns list.
Summary: Add column reflection of dcol elements into datagrid's columns list.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 26546
  Show dependency treegraph
 
Reported: 2009-06-30 13:51 PDT by Dave Hyatt
Modified: 2009-06-30 14:39 PDT (History)
1 user (show)

See Also:


Attachments
Patch (15.96 KB, patch)
2009-06-30 13:55 PDT, Dave Hyatt
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2009-06-30 13:51:34 PDT
This covers getting the basics working.  Stuff still needs to update when attributes change.
Comment 1 Dave Hyatt 2009-06-30 13:55:22 PDT
Created attachment 32092 [details]
Patch
Comment 2 Beth Dakin 2009-06-30 14:03:15 PDT
Comment on attachment 32092 [details]
Patch

id HTMLDataGridColElement::removedFromTree(bool deep)
> +{
> +    HTMLElement::removedFromTree(deep);
> +    if (datagrid() && datagrid()->dataSource()->isDOMDataGridDataSource()) {
> +        HTMLDataGridElement* grid = findDatagridAncestor();
> +        if (!grid && column()) {
> +            datagrid()->columns()->remove(column());
> +            m_datagrid = 0;
> +        }
> +    }
> +}


I find this a little confusing. What is the difference between datagrid() and the result of findDatagridAncestor().I would expect them to be the same.

r=me!
Comment 3 Dave Hyatt 2009-06-30 14:34:15 PDT
This is kind of like forms.... how stuff is cached in m_form, but you aren't really leaving the form unless you are truly disconnected from it in the ancestor chain... so you have to have a separate find method to test this out.
Comment 4 Dave Hyatt 2009-06-30 14:39:28 PDT
Fixed in r45397.