RESOLVED FIXED 268543
[LBSE] Expand test coverage
https://bugs.webkit.org/show_bug.cgi?id=268543
Summary [LBSE] Expand test coverage
Nikolas Zimmermann
Reported 2024-02-01 04:35:43 PST
Up until now we only had mac-wk2-pixel baselines (legacy SVG engine, pixel tests using macOS Sonoma 14.3) and Mac-wk2-lbse-text (text results + rare pixel test exceptions for all tests, but with LSE enabled) for the LayoutTests/svg/ subdirectory. This was enough for initial bootstrapping, but now that most basic painting features are implemented, it makes sense to run all of WPT as well (+ css3/masking, since it contains important HTML/CSS clipping/masking tests utilizing SVG resources). The idea is that I first generate, as usual, a macOS 14.3 pixel test baseline for the whole WPT 'svg' directory, placed in 'mac-wk2-pixel' (only needs a few Sonoma specific exceptions, most results are shared with platform/Mac). Then I generate a LBSE-enabled baseline, placed in 'Mac-wk2-lbse-text' that contains the LBSE specific render tree dumps + pixel test results, where needed. The failing tests, where a text-rebaseline is not enough, and the pixel test clearly differs, are marked as such in the 'TestExpectations' file in the 'mac-wk2-lbse-text' directory.
Attachments
Nikolas Zimmermann
Comment 1 2024-02-01 06:14:26 PST
EWS
Comment 2 2024-02-01 06:22:33 PST
Committed 273904@main (6e71fb56de83): <https://commits.webkit.org/273904@main> Reviewed commits have been landed. Closing PR #23667 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-02-01 06:23:13 PST
Note You need to log in before you can comment on or make changes to this bug.