Created attachment 469644 [details] test case REGRESSION: line-clamp doesn't work as expected with inline-block children
Created attachment 469645 [details] [screenshot] STP 184
I did bisecting with my WinCairo collection. 256506@main good 256728@main bad
My coworker did more bisecting. He says that 256989@main is the regression point.
(In reply to Fujii Hironori from comment #2) > I did bisecting with my WinCairo collection. > > 256506@main good > 256728@main bad My bad. This is my real result. 256728@main good 257047@main bad
Created attachment 469652 [details] broken line clamp (not a regression) Yeah, it looks like a regression caused by switching over to the new line-clamp implementation, but running line-clamp on inline-block was never really thought through (see screenshot attached, which is a slightly modified version of the test case where the inline text content is nested inside a block container <div>0 1 2 ...)
(In reply to zalan from comment #5) > Created attachment 469652 [details] > broken line clamp (not a regression) > > Yeah, it looks like a regression caused by switching over to the new > line-clamp implementation, but running line-clamp on inline-block was never > really thought through (see screenshot attached, which is a slightly > modified version of the test case where the inline text content is nested > inside a block container <div>0 1 2 ...) <!DOCTYPE html> <html><head> <style> .paragraph { display: -webkit-box; overflow: hidden; -webkit-box-orient: vertical; -webkit-line-clamp: 3; line-clamp: 3; } span.a { background: green; display: inline-block; } </style> </head> <body> <div class="paragraph"><div> 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100</div> <span class=a>xxx</span> <span class=a>xxx</span> </div> </body></html>
Your test case (comment#6) works as expected with my STP. It shows only the first three lines. It doesn't yield comment#5 screenshot result. Your screenshot looks like overflow:hidden removed. Right?
(In reply to Fujii Hironori from comment #7) > Your test case (comment#6) works as expected with my STP. It shows only the > first three lines. It doesn't yield comment#5 screenshot result. > Your screenshot looks like overflow:hidden removed. Right? the screenshot shows the rendering when the new line clamp implementation is disabled (essentially what we had before 256989@main)
Your comment#5 screenshot looks like a correct result. It shows "..." at the bottom of the third line. It is the expected behavior of -webkit-line-clamp:3.
(In reply to Fujii Hironori from comment #9) > Your comment#5 screenshot looks like a correct result. > It shows "..." at the bottom of the third line. > It is the expected behavior of -webkit-line-clamp:3. You are right, the ellipsis placement is correct, but that's pretty much the only thing that looks ok in there. It is surely not an overall desired rendering where the inline-block box _overlaps_ adjacent content and the block height is off by one line box.
<rdar://problem/122516297>
Created attachment 469872 [details] Patch to work around