RESOLVED FIXED268510
webkitpy/layout_tests/models/test_run_results_unittest.py can be very slow 
https://bugs.webkit.org/show_bug.cgi?id=268510
Summary webkitpy/layout_tests/models/test_run_results_unittest.py can be very slow
Sam Sneddon [:gsnedders]
Reported 2024-01-31 16:17:13 PST
A bunch of these are by far the slowest tests in layout_tests: 14.09s call layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_summarized_results_world_leaks_disabled 14.05s call layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_summarized_run_metadata 14.03s call layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_git_revision_exists 14.03s call layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_summarized_results_wontfix 14.00s call layout_tests/models/test_run_results_unittest.py::SummarizedResultsTest::test_summarized_results_include_passes Unit tests that take that long to run are *painful*. This time is almost entirely within webkitpy/port/base.py:1471(commits_for_upload), because this ultimately ends up calling `git branch --contains [HEAD] -a`, which on a WebKit tree with large numbers of remotes is *slow*. Almost none of these tests actually care about revision *at all*, so just using a mock should be fine here.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2024-01-31 16:24:41 PST
Pull request: https://github.com/WebKit/WebKit/pull/23628
EWS
Comment 2 2024-02-01 15:33:31 PST
Committed 273948@main (7df0ea213a3f): <https://commits.webkit.org/273948@main> Reviewed commits have been landed. Closing PR #23628 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-02-01 15:34:15 PST
<rdar://problem/122137154>
Note You need to log in before you can comment on or make changes to this bug.