WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
268479
REGRESSION (
234750@main
): [GTK][WPE] preferred language not passed to NetworkProcess if set in WebContext before creating WebView
https://bugs.webkit.org/show_bug.cgi?id=268479
Summary
REGRESSION (234750@main): [GTK][WPE] preferred language not passed to Network...
Olivier Blin
Reported
2024-01-31 09:56:43 PST
In GLib ports, since
234750@main
, the user preferred language is not properly passed to the NetworkProcess if it is set in WebContext before creating the WebView. This causes a wrong Accept-Language header in HTTP requests sent with libsoup. The webkit_web_context_set_preferred_languages() API can be called before passing the WebContext at WebView creation. Since
234750@main
, this function calls the setOverrideLanguages() WebProcessPool API instead of the overrideUserPreferredLanguages() WTF API. So WebProcessPool::platformInitializeNetworkProcess() can not get the real preferred language from the userPreferredLanguages() WTF API. Instead, the NetworkProcess creation should use the overrideLanguages() WebProcessPool API, like already done for the WebProcess creation parameters (see also
226031@main
).
Attachments
Add attachment
proposed patch, testcase, etc.
Olivier Blin
Comment 1
2024-01-31 10:01:41 PST
Pull request:
https://github.com/WebKit/WebKit/pull/23596
EWS
Comment 2
2024-02-02 12:58:20 PST
Committed
274011@main
(f2599adbe881): <
https://commits.webkit.org/274011@main
> Reviewed commits have been landed. Closing PR #23596 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug