Bug 26847 - [Chromium] Delete ResourceRequest::securityInfo
Summary: [Chromium] Delete ResourceRequest::securityInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-30 10:26 PDT by Darin Fisher (:fishd, Google)
Modified: 2009-12-30 20:59 PST (History)
3 users (show)

See Also:

Attachments
v1 patch (3.80 KB, patch)
2009-12-09 11:11 PST, Darin Fisher (:fishd, Google) 		no flags Details | Formatted Diff | Diff
Re-posting to get chromium-ews run (3.73 KB, patch)
2009-12-30 18:52 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-06-30 10:26:38 PDT 
[Chromium] Delete ResourceRequest::securityInfo
Comment 1 Darin Fisher (:fishd, Google) 2009-06-30 10:29:21 PDT 
The securityInfo string is a serialization of SSL certificate information used for determining the security state of a connection.  This is a property of ResourceResponse so that we can store SSL certificate information in the WebCore cache.  It is also a property of ResourceRequest so that when we load error pages, we have a way to pass SSL certificate information along.  However, that can also be handled entirely within Chromium, and that is what I am doing.  I think it is cleaner to leave securityInfo out of ResourceRequest.
Comment 2 Darin Fisher (:fishd, Google) 2009-12-09 11:11:06 PST 
Created attachment 44548 [details]
v1 patch
Comment 3 WebKit Review Bot 2009-12-09 11:12:03 PST 
style-queue ran check-webkit-style on attachment 44548 [details] without any errors.
Comment 4 David Levin 2009-12-09 15:20:14 PST 
Comment on attachment 44548 [details]
v1 patch

> Index: WebKit/chromium/src/WebWorkerBase.cpp
> -    ResourceRequest request(url, CString());
> -    webFrame->frame()->loader()->load(request, substData, false);
> +    webFrame->frame()->loader()->load(ResourceRequest(url), substData, false);

I suspect that gcc won't like this line (since load takes a const ResourceRequest&) -- I seem to remember needing a variable for cases like this when compiling with gcc.
Comment 5 Eric Seidel (no email) 2009-12-28 22:58:45 PST 
Ping?  This has been r+'d for 20 days now.  (I assume it got forgotten due to holiday fun.)  If it should be cq+'d or closed, be my guest. :)
Comment 6 Adam Barth 2009-12-30 18:52:13 PST 
Created attachment 45694 [details]
Re-posting to get chromium-ews run
Comment 7 WebKit Review Bot 2009-12-30 18:54:04 PST 
style-queue ran check-webkit-style on attachment 45694 [details] without any errors.
Comment 8 Adam Barth 2009-12-30 20:46:52 PST 
Comment on attachment 45694 [details]
Re-posting to get chromium-ews run

This was already r+ed by David Levin and passed the EWS.  Looks safe to land.
Comment 9 WebKit Commit Bot 2009-12-30 20:59:05 PST 
Comment on attachment 45694 [details]
Re-posting to get chromium-ews run

Clearing flags on attachment: 45694

Committed r52677: <http://trac.webkit.org/changeset/52677>
Comment 10 WebKit Commit Bot 2009-12-30 20:59:12 PST 
All reviewed patches have been landed.  Closing bug.