Bug 26847 – [Chromium] Delete ResourceRequest::securityInfo

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Darin Fisher (:fishd, Google)]

[Chromium] Delete ResourceRequest::securityInfo

[Darin Fisher (:fishd, Google)]

The securityInfo string is a serialization of SSL certificate information used for determining the security state of a connection.  This is a property of ResourceResponse so that we can store SSL certificate information in the WebCore cache.  It is also a property of ResourceRequest so that when we load error pages, we have a way to pass SSL certificate information along.  However, that can also be handled entirely within Chromium, and that is what I am doing.  I think it is cleaner to leave securityInfo out of ResourceRequest.

[Darin Fisher (:fishd, Google)]

Created attachment 44548 [details]
v1 patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44548 [details] without any errors.

[David Levin]

Comment on attachment 44548 [details]
v1 patch

> Index: WebKit/chromium/src/WebWorkerBase.cpp
> -    ResourceRequest request(url, CString());
> -    webFrame->frame()->loader()->load(request, substData, false);
> +    webFrame->frame()->loader()->load(ResourceRequest(url), substData, false);

I suspect that gcc won't like this line (since load takes a const ResourceRequest&) -- I seem to remember needing a variable for cases like this when compiling with gcc.

[Eric Seidel (no email)]

Ping?  This has been r+'d for 20 days now.  (I assume it got forgotten due to holiday fun.)  If it should be cq+'d or closed, be my guest. :)

[Adam Barth]

Created attachment 45694 [details]
Re-posting to get chromium-ews run

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45694 [details] without any errors.

[Adam Barth]

Comment on attachment 45694 [details]
Re-posting to get chromium-ews run

This was already r+ed by David Levin and passed the EWS.  Looks safe to land.

[WebKit Commit Bot]

Comment on attachment 45694 [details]
Re-posting to get chromium-ews run

Clearing flags on attachment: 45694

Committed r52677: <http://trac.webkit.org/changeset/52677>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.