Bug 268413 – [results database] Loading more than one test and removing any after the 2nd test messes with the URI

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Zhifei Fang]

Loading more than one test and removing any after the 2nd test messes with the URI

[Zhifei Fang]

Pull request: https://github.com/WebKit/WebKit/pull/23540

[Zhifei Fang]

rdar://116684238

[EWS]

Committed 273877@main (0d37807b0e51): <https://commits.webkit.org/273877@main>

Reviewed commits have been landed. Closing PR #23540 and removing active labels.

[Ben Schwartz]

Since there's another bug open for a similar issue, I'm going to post some more specific information about this partially fixed bug.

___________________

Summary:
On the results dashboard, loading multiple tests will populate them out of order on the page (the first one loads correctly but all of the following tests are loaded in opposite order); however, the request URI is loaded in the order you pasted the tests.

Pressing "X" on any of the tests will remove the test in the position it appears on the page, but it will remove the test at the same position in the URI. So, if the tests are loaded out of order and "X" is pressed, reloading will remove the wrong test from the results since it loads from the errantly modified URI.

Steps To Reproduce:
1. Paste a list of more than 2 tests (or add more than 2 tests individually to the page).
2. Remove one of the tests after the second test.

Results:
- Expected: URI and tests are populated/modified in the correct order.
- Actual: URI is populated in the correct order, but tests are not. Clicking "X" will modify the URI at the position the target test appeared, not at the appropriate URI position for the test (which will end up removing the wrong test from future page loads).