NEW 268403
Make webkitpy.common.checkout.scm.SCM.create_patch less odd 
https://bugs.webkit.org/show_bug.cgi?id=268403
Summary Make webkitpy.common.checkout.scm.SCM.create_patch less odd
Sam Sneddon [:gsnedders]
Reported 2024-01-30 12:50:48 PST
c.f. https://github.com/WebKit/WebKit/pull/20686#discussion_r1408349715 Currently, SCM.create_patch returns *either* an mbox of patches or a unified diff, depending on the commit_message kwarg. Returning an mbox of patches is something we can totally do—but we probably shouldn't have a method called "create_patch" returning an mbox. A quick glance suggests we have almost nowhere left that actually calls with it commit_message=True, so maybe we can simply remove the mbox code path?
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-06 12:51:25 PST
<rdar://problem/122416603>
Note You need to log in before you can comment on or make changes to this bug.