WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
268379
TestShard can't actually pickle reference_files
https://bugs.webkit.org/show_bug.cgi?id=268379
Summary
TestShard can't actually pickle reference_files
Sam Sneddon [:gsnedders]
Reported
2024-01-30 06:55:08 PST
self = TestShard(name='failures/expected', test_inputs=[TestInput(test=Test(test_path='failures/expected/empty.html', expecte...=None, should_dump_jsconsolelog_in_stderr=None, reference_files=None, should_run_pixel_test=None)], needs_servers=None' string = ('!=', '/test.checkout/LayoutTests/failures/expected/mismatch-expected-mismatch.html') def shorten(self, string): if not string: return string
> return string.replace('{}/'.format(self.name), '{}')
E AttributeError: 'tuple' object has no attribute 'replace' layout_tests/controllers/layout_test_runner.py:511: AttributeError
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1
2024-01-30 07:32:52 PST
Pull request:
https://github.com/WebKit/WebKit/pull/23512
EWS
Comment 2
2024-01-30 14:18:43 PST
Committed
273789@main
(5d4d9c7ef39a): <
https://commits.webkit.org/273789@main
> Reviewed commits have been landed. Closing PR #23512 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-01-30 14:19:20 PST
<
rdar://problem/121959570
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug