Bug 26833 - Add BeautifulSoup to WebKitTools/Scripts/modules so that folks don't need to install it
Summary: Add BeautifulSoup to WebKitTools/Scripts/modules so that folks don't need to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 26834
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-30 01:25 PDT by Eric Seidel (no email)
Modified: 2009-06-30 02:34 PDT (History)
3 users (show)

See Also:


Attachments
Add BeautifulSoup (84.04 KB, patch)
2009-06-30 01:42 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Add BeautifulSoup (and fix post-diff to not hang with large patches) (84.45 KB, patch)
2009-06-30 01:44 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Add BeautifulSoup, now w/o any create_patch changes (81.42 KB, patch)
2009-06-30 02:08 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-06-30 01:25:28 PDT
Add BeautifulSoup to WebKitTools/Scripts/modules so that folks don't need to install it
Comment 1 Eric Seidel (no email) 2009-06-30 01:42:11 PDT
Created attachment 32039 [details]
Add BeautifulSoup
Comment 2 Eric Seidel (no email) 2009-06-30 01:44:57 PDT
Created attachment 32040 [details]
Add BeautifulSoup (and fix post-diff to not hang with large patches)
Comment 3 Mark Rowe (bdash) 2009-06-30 01:46:17 PDT
Comment on attachment 32040 [details]
Add BeautifulSoup (and fix post-diff to not hang with large patches)

This patch does two completely unrelated things.
Comment 4 Eric Seidel (no email) 2009-06-30 02:08:59 PDT
Created attachment 32043 [details]
Add BeautifulSoup, now w/o any create_patch changes
Comment 5 Maciej Stachowiak 2009-06-30 02:31:05 PDT
Comment on attachment 32043 [details]
Add BeautifulSoup, now w/o any create_patch changes

r=me

I only reviewed the license and the changes outside of BeautifulSoup itself. The license seems WebKit-compatible.
Comment 6 Eric Seidel (no email) 2009-06-30 02:34:10 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	A	WebKitTools/Scripts/modules/BeautifulSoup.py
	M	WebKitTools/Scripts/modules/bugzilla.py
Committed r45369
http://trac.webkit.org/changeset/45369