Bug 26832 – Generalize special height handling in InlineBox

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Roland Steiner]

InlineBox contains a bit that is used to mark when a box computes its height differently from the default. This bit is currently used only for SVG (and used instead of virtual methods for performance reasons) and hence named 'm_isSVG'.

This bit should have a generic name that fits its purpose so that it can be re-used.

The implementation for ruby will make use of this.

[Roland Steiner]

(In reply to comment #0)

Addendum: This of course also applies to all methods that make use of this bit (isSVG, setIsSVG, svgBoxheight).

> InlineBox contains a bit that is used to mark when a box computes its height
> differently from the default. This bit is currently used only for SVG (and used
> instead of virtual methods for performance reasons) and hence named 'm_isSVG'.
> 
> This bit should have a generic name that fits its purpose so that it can be
> re-used.
> 
> The implementation for ruby will make use of this.
> 

[Roland Steiner]

Created attachment 32036 [details]
patch: implement proposed renaming

[Eric Seidel (no email)]

Comment on attachment 32036 [details]
patch: implement proposed renaming

It seems this should still be wrapped in ENABLE(SVG) || ENABLE(RUBY) blocks.

maybe m_useVirtualHeight would be more clear?  I'm not sure.  I'm just not sure what a "special height" is.

[Roland Steiner]

Created attachment 32110 [details]
patch: renamed to 'virtualHeight'

You're right, 'virtualheight' probably is more clear.

Updated patch accordingly.

[Maciej Stachowiak]

Comment on attachment 32110 [details]
patch: renamed to 'virtualHeight'

r=me

[Roland Steiner]

(In reply to comment #5)

Thanks a lot for the review! Can I ask you to commit the patch for me, please?

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/InlineBox.cpp
	M	WebCore/rendering/InlineBox.h
	M	WebCore/rendering/RenderSVGInline.cpp
	M	WebCore/rendering/RenderSVGInlineText.cpp
	M	WebCore/rendering/RenderSVGText.cpp
	M	WebCore/rendering/SVGInlineFlowBox.h
	M	WebCore/rendering/SVGInlineTextBox.h
	M	WebCore/rendering/SVGRootInlineBox.h
Committed r45570
	M	WebCore/ChangeLog
	M	WebCore/rendering/InlineBox.cpp
	M	WebCore/rendering/RenderSVGInlineText.cpp
	M	WebCore/rendering/SVGInlineTextBox.h
	M	WebCore/rendering/SVGInlineFlowBox.h
	M	WebCore/rendering/RenderSVGText.cpp
	M	WebCore/rendering/RenderSVGInline.cpp
	M	WebCore/rendering/SVGRootInlineBox.h
	M	WebCore/rendering/InlineBox.h
r45570 = 0bc3a1356efe435f43de58095372a73b869cb918 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/45570