Bug 268314 - Protect WebProcess::unblockServicesRequiredByAccessibility from attempting to consume nullptr sandbox extensions
Summary: Protect WebProcess::unblockServicesRequiredByAccessibility from attempting to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-29 11:28 PST by Brent Fulgham
Modified: 2024-01-29 20:23 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2024-01-29 11:28:32 PST 
The code in WebProcess::unblockServicesRequiredByAccessibility assumes that it will always work with non-nullptr Sandbox Extensions. However, it's possible for the SandboxExtension::create() method to return nullptr, so we should harden this code to avoid crashing under such conditions.

<rdar://121746329>
Comment 1 Brent Fulgham 2024-01-29 11:33:30 PST 
Pull request: https://github.com/WebKit/WebKit/pull/23442
Comment 2 EWS 2024-01-29 20:23:51 PST 
Committed 273719@main (a68ad5db5c83): <https://commits.webkit.org/273719@main>

Reviewed commits have been landed. Closing PR #23442 and removing active labels.