Bug 26828 - Confusing method naming: createRoot[Inline]Box, create[Inline]FlowBox
Summary: Confusing method naming: createRoot[Inline]Box, create[Inline]FlowBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-29 22:02 PDT by Roland Steiner
Modified: 2009-07-02 18:29 PDT (History)
0 users

See Also:

Attachments
patch: rename methods to createAndAppend...() (7.98 KB, patch)
2009-06-29 22:03 PDT, Roland Steiner 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2009-06-29 22:02:02 PDT 
RenderBlock and RenderInline have confusingly named object creation methods:

RenderBlock::createRootBox/createRootInlineBox
RenderInline::createFlowBox/createInlineFlowBox

where the 2nd method in both cases just calls the first and then appends the created object, i.e., is not really a different object creation method, and doesn't create different objects.

Also confusing because there are no "RootBox" or "FlowBox" classes.
Comment 1 Roland Steiner 2009-06-29 22:03:01 PDT 
Created attachment 32032 [details]
patch: rename methods to createAndAppend...()
Comment 2 Eric Seidel (no email) 2009-06-30 00:48:03 PDT 
Comment on attachment 32032 [details]
patch: rename methods to createAndAppend...()

Looks great!
Comment 3 Roland Steiner 2009-06-30 21:55:12 PDT 
(In reply to comment #2)
> (From update of attachment 32032 [details] [review])
> Looks great!

Thanks! Could you please commit the patch for me?
Comment 4 Eric Seidel (no email) 2009-07-02 18:28:43 PDT 
There were tab characters in the ChangeLog, and the ChangeLog was missing the bug URL.  I corrected these when landing.
Comment 5 Eric Seidel (no email) 2009-07-02 18:29:12 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/RenderBlock.h
	M	WebCore/rendering/RenderInline.cpp
	M	WebCore/rendering/RenderInline.h
	M	WebCore/rendering/RenderSVGInline.cpp
	M	WebCore/rendering/RenderSVGInline.h
	M	WebCore/rendering/RenderSVGText.cpp
	M	WebCore/rendering/RenderSVGText.h
	M	WebCore/rendering/bidi.cpp
Committed r45517
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderSVGInline.h
	M	WebCore/rendering/RenderSVGText.h
	M	WebCore/rendering/RenderInline.cpp
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/bidi.cpp
	M	WebCore/rendering/RenderInline.h
	M	WebCore/rendering/RenderBlock.h
	M	WebCore/rendering/RenderSVGText.cpp
	M	WebCore/rendering/RenderSVGInline.cpp
r45517 = a2815d0bab937dd4b3bfc42ffd13b5d7a3b7a0fc (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/45517