Bug 268267 - Rename argument 'xValue' for 'setY' function in SVGRect.h
Summary: Rename argument 'xValue' for 'setY' function in SVGRect.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-28 17:06 PST by Ahmad Saleem
Modified: 2024-01-28 19:02 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2024-01-28 17:06:13 PST 
Hi Team,

It is just simple rename since xValue seems to be more appropriate for setX() in SVGRect.h while yValue would make more sense for setY().

So I thought to raise this bug so I can do quick PR to make it easier to understand.

WebKit Source: https://searchfox.org/wubkat/rev/77fb3649ec46dea08154a9f96e0d06fd5b9cb0bf/Source/WebCore/svg/SVGRect.h#66

Thanks!
Comment 1 EWS 2024-01-28 19:01:26 PST 
Committed 273636@main (d7621ef52d44): <https://commits.webkit.org/273636@main>

Reviewed commits have been landed. Closing PR #23401 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2024-01-28 19:02:15 PST 
<rdar://problem/121825105>