Bug 268223 – XML Document Viewer should have dark mode

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Ahmad Saleem]

Hi Team,

Open following: https://www.w3schools.com/xml/note.xml

Despite system settings being dark, this is still 'white' (eye sore - LOL!).

We should update it to respect dark mode.

WebKit Source: https://searchfox.org/wubkat/rev/b96b33ee6c4c6dde7bf51c3744d6ccbc19a517e8/Source/WebCore/xml/XMLViewer.css

We need to add respective CSS - I believe.

It is easy fix I think.

Thanks!

[Ahmad Saleem]

Few changes inspired from Chromium / Blink: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/xml/DocumentXMLTreeViewer.css;l=1;drc=047c7dc4ee1ce908d7fea38ca063fa2f80f92c77

>> Remove 'body { margin: 0; } <- We already have in html.css for margin: 8px

>> Align (collapse-button and expand-button) to have same height.

>> In (collapse-button and expand-button) and use background - svg image similar to Blink rather than -webkit-canvas.

>> For dark mode:

root {
    color-scheme: light dark;
}

@media (prefers-color-scheme: dark) {
    div.header {
        border-bottom: 2px solid white;
    }
}

___

[Ahmad Saleem]

Created attachment 469569 [details]
Local Build Screenshot Reference

STP187 vs Minibrowser (local build)

[Frances Cornwall]

I am relating/it is a duplicate of bug 267604.

[Radar WebKit Bug Importer]

<rdar://problem/122234600>

[zak ridouh]

Pull request: https://github.com/WebKit/WebKit/pull/59345

[EWS]

Committed 316832@main (b019fc2aabbe): <https://commits.webkit.org/316832@main>

Reviewed commits have been landed. Closing PR #59345 and removing active labels.