RESOLVED DUPLICATE of bug 265030 268060
`check-webkit-style --git-index` fails with error 
https://bugs.webkit.org/show_bug.cgi?id=268060
Summary `check-webkit-style --git-index` fails with error
Simon Fraser (smfr)
Reported 2024-01-24 21:39:45 PST
OpenSource % ./Tools/Scripts/check-webkit-style --git-index Traceback (most recent call last): File "/Volumes/Data/Development/system/webkit/OpenSource/./Tools/Scripts/check-webkit-style", line 46, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/style/main.py", line 157, in main patch = host.scm().create_patch(options.git_commit, changed_files=changed_files, git_index=options.git_index, find_branch=True) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 376, in create_patch assert command[1] == 'diff' AssertionError
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-01-31 21:40:13 PST
<rdar://problem/122068513>
Jonathan Bedard
Comment 2 2024-04-04 17:21:49 PDT
I can't reproduce this. Is there any more information about the state of your checkout when encountering this error? Looking at the code, I suspect this has something to do with generating a patch with a commit message instead of just a diff, so it's probably related to to being on a PR branch vs main and then having a commit vs just changed files.
Jonathan Bedard
Comment 3 2024-04-05 09:49:33 PDT
User says this works for them now, closing this bug.
Sam Sneddon [:gsnedders]
Comment 4 2024-04-06 15:53:52 PDT
This will've been fixed by bug 265030, 273780@main. *** This bug has been marked as a duplicate of bug 265030 ***
Note You need to log in before you can comment on or make changes to this bug.