Bug 268019 - [JSC] Computed property keys of class fields should not be reparsed
Summary: [JSC] Computed property keys of class fields should not be reparsed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks: 262405
  Show dependency tree / graph
 
Reported: 2024-01-24 11:07 PST by Alexey Shvayka
Modified: 2024-01-29 12:10 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2024-01-24 11:07:12 PST 
because parsing is context-based, and some context like allowance of yield / async is lost when invoking parseClassFieldInitializerSourceElements().
Comment 1 Radar WebKit Bug Importer 2024-01-24 11:07:39 PST 
<rdar://problem/121538219>
Comment 2 Alexey Shvayka 2024-01-24 11:18:19 PST 
Related test262 failures:
  * test/language/expressions/class/cpn-class-expr-fields-computed-property-name-from-yield-expression.js
  * test/language/expressions/class/cpn-class-expr-fields-methods-computed-property-name-from-yield-expression.js
  * test/language/statements/class/cpn-class-decl-fields-computed-property-name-from-yield-expression.js
  * test/language/statements/class/cpn-class-decl-fields-methods-computed-property-name-from-yield-expression.js
Comment 3 Alexey Shvayka 2024-01-24 12:20:15 PST 
Pull request: https://github.com/WebKit/WebKit/pull/23184
Comment 4 EWS 2024-01-29 12:10:30 PST 
Committed 273677@main (5553144b15b7): <https://commits.webkit.org/273677@main>

Reviewed commits have been landed. Closing PR #23184 and removing active labels.