Bug 267947 - [JSC][armv7] Re-enable DFG after CallIC changes
Summary: [JSC][armv7] Re-enable DFG after CallIC changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-23 13:18 PST by Joseph Griego
Modified: 2024-01-24 08:51 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Griego 2024-01-23 13:18:28 PST 
After https://bugs.webkit.org/show_bug.cgi?id=267681, DFG was broken on armv7 and was disabled.

However, this breakage was due to DFG calls not checking the tag word of the callee and also skipping part of the tail-call preparation due to an old, unused patchable branch; incidentally, both were fixed in https://bugs.webkit.org/show_bug.cgi?id=267802, so, we can re-enable DFG if test cases are passing again.
Comment 1 Joseph Griego 2024-01-23 13:20:00 PST 
Pull request: https://github.com/WebKit/WebKit/pull/23120
Comment 2 EWS 2024-01-24 08:50:33 PST 
Committed 273415@main (22599e19e5d7): <https://commits.webkit.org/273415@main>

Reviewed commits have been landed. Closing PR #23120 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-01-24 08:51:14 PST 
<rdar://problem/121525912>