Bug 26794 - Make Yacc-generated parsers to use fastMalloc/fastFree
Summary: Make Yacc-generated parsers to use fastMalloc/fastFree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-29 03:17 PDT by Kwang Yul Seo
Modified: 2009-07-15 13:55 PDT (History)
1 user (show)

See Also:

Attachments
Use fastMalloc/fastFree in Yacc-generated parsers (1.87 KB, patch)
2009-06-29 03:18 PDT, Kwang Yul Seo 		eric: review-
Details | Formatted Diff | Diff
Use fastMalloc/fastFree in Yacc-generated parsers (3.14 KB, patch)
2009-06-30 01:21 PDT, Kwang Yul Seo 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2009-06-29 03:17:57 PDT 
Make Yacc-generated parsers to use fastMalloc/fastFree by defining YYMALLOC and YYFREE to fastMalloc and fastFree respectively.

The following three parsers are changed.

- JavaScriptCore/parser/Grammar.y
- WebCore/xml/XPathGrammar.y
- WebCore/css/CSSGrammar.y
Comment 1 Kwang Yul Seo 2009-06-29 03:18:50 PDT 
Created attachment 32005 [details]
Use fastMalloc/fastFree in Yacc-generated parsers
Comment 2 Eric Seidel (no email) 2009-06-30 00:44:11 PDT 
Comment on attachment 32005 [details]
Use fastMalloc/fastFree in Yacc-generated parsers

This looks great, but is missing a ChangeLog:
http://webkit.org/coding/contributing.html
Comment 3 Kwang Yul Seo 2009-06-30 01:21:59 PDT 
Created attachment 32037 [details]
Use fastMalloc/fastFree in Yacc-generated parsers
Comment 4 Kwang Yul Seo 2009-06-30 01:22:50 PDT 
Comment on attachment 32037 [details]
Use fastMalloc/fastFree in Yacc-generated parsers


ChangeLogs are added
Comment 5 Eric Seidel (no email) 2009-06-30 02:45:09 PDT 
Comment on attachment 32037 [details]
Use fastMalloc/fastFree in Yacc-generated parsers


Looks good to me.
Comment 6 Brent Fulgham 2009-07-15 13:55:30 PDT 
Landed in http://trac.webkit.org/changeset/45943.