RESOLVED FIXED 267813
Explore to remove WheelEvent.initWebKitWheelEvent()
https://bugs.webkit.org/show_bug.cgi?id=267813
Summary Explore to remove WheelEvent.initWebKitWheelEvent()
Ahmad Saleem
Reported 2024-01-20 05:59:40 PST
Hi Team, It was removed from Blink in 2014. Prefixed API - https://trac.webkit.org/wiki/PrefixedAPIs <- We should replicate this on docs.webkit.org as well. Good page and would be good to add relevant bug links as well to make it easier for future tracking. Blink Intent To Remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/h_GoezQ4MQ4/m/Q5abFkhA76sJ Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=179230 WebKit Source: https://searchfox.org/wubkat/rev/90f2bafbe99f4ab1ec05cd05d975c0bbd9aa3ad4/Source/WebCore/dom/WheelEvent.cpp#89 , https://searchfox.org/wubkat/rev/90f2bafbe99f4ab1ec05cd05d975c0bbd9aa3ad4/Source/WebCore/dom/WheelEvent.idl#44 etc. __ Just wanted to raise, I think it would be good clean-up. Appreciate if someone can share input from 'Apple' perspective whether it is OK to remove or their are still internal usage etc. Thanks!
Attachments
Ahmad Saleem
Comment 1 2024-01-20 06:08:13 PST
We pass this WPT: https://wpt.fyi/results/uievents/historical.html?label=master&label=experimental&aligned=&q=uievents I am reading the code etc. wrong or this is just clean-up or used for other purposes but not exposed?
Anne van Kesteren
Comment 2 2024-01-20 23:45:11 PST
The WPT is only testing initWheelEvent(), not initWebKitWheelEvent().
Ahmad Saleem
Comment 3 2024-01-24 10:49:25 PST
(In reply to Anne van Kesteren from comment #2) > The WPT is only testing initWheelEvent(), not initWebKitWheelEvent(). https://jsfiddle.net/d7ur5b6m/show Updated it in above JSFiddle and we fail 'prefixed' one. :-)
Radar WebKit Bug Importer
Comment 4 2024-01-27 06:00:14 PST
Ahmad Saleem
Comment 5 2024-02-03 14:02:10 PST
*** Bug 76124 has been marked as a duplicate of this bug. ***
EWS
Comment 6 2024-02-04 08:16:34 PST
Committed 274069@main (f50de885e127): <https://commits.webkit.org/274069@main> Reviewed commits have been landed. Closing PR #23812 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.