Bug 26779 - [Qt] Fix build break for Qt
Summary: [Qt] Fix build break for Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-27 20:26 PDT by Sriram
Modified: 2009-06-28 05:41 PDT (History)
0 users

See Also:


Attachments
Patch for Qt build break (2.58 KB, patch)
2009-06-27 20:38 PDT, Sriram
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sriram 2009-06-27 20:26:12 PDT
Build break introduced due to changes in http://trac.webkit.org/changeset/45304 and in http://trac.webkit.org/changeset/45290
Comment 1 Jan Alonzo 2009-06-27 20:32:55 PDT
(In reply to comment #0)
> Build break introduced due to changes in http://trac.webkit.org/changeset/45304
> and in http://trac.webkit.org/changeset/45290
> 

Bug #26769 already fixes the build break caused by r45290.
Comment 2 Sriram 2009-06-27 20:38:18 PDT
Created attachment 31986 [details]
Patch for Qt build break
Comment 3 Jan Alonzo 2009-06-27 20:43:39 PDT
Comment on attachment 31986 [details]
Patch for Qt build break

> Index: ../../WebCore/WebCore.pro
> ===================================================================
> --- ../../WebCore/WebCore.pro	(revision 45314)
> +++ ../../WebCore/WebCore.pro	(working copy)
> @@ -1366,20 +1366,19 @@
>      HEADERS += \
>          storage/Storage.h \
>          storage/StorageEvent.h \
> -        storage/SessionStorage.h \
>          storage/StorageSyncManager.h \
> +        storage/StorageNameSpace.h \
>          storage/StorageAreaSync.h
>  
>      SOURCES += \
> -        storage/LocalStorage.cpp \
>          storage/LocalStorageTask.cpp \
>          storage/LocalStorageThread.cpp \
>          storage/Storage.cpp \
> +        storage/StorageNameSpace.cpp \
>          storage/StorageArea.cpp \
>          storage/StorageAreaSync.cpp \
>          storage/StorageMap.cpp \
>          storage/StorageEvent.cpp \
> -        storage/SessionStorage.cpp \
>          storage/StorageSyncManager.cpp \
>          bindings/js/JSStorageCustom.cpp

Please don't include this. See comment #1.
Comment 4 Eric Seidel (no email) 2009-06-28 02:49:09 PDT
Comment on attachment 31986 [details]
Patch for Qt build break

I think part of this may already be in.  Looks fine.
Comment 5 Jan Alonzo 2009-06-28 05:41:00 PDT
(In reply to comment #4)
> (From update of attachment 31986 [details] [review])
> I think part of this may already be in.  Looks fine.
> 

Landed in r45329