NEW 267742
[git-webkit pr] Retry is not uploading commit with changes 
https://bugs.webkit.org/show_bug.cgi?id=267742
Summary [git-webkit pr] Retry is not uploading commit with changes
Brianna Fan
Reported 2024-01-18 16:49:31 PST
Inputting "retry" after the style checker finds issues in a commit will result in no errors on command line, but when checking the commit on GitHub, the fixes are not uploaded. For example, total errors become 0 after retry, but the whitespaces are still present in the force-pushed commit. ` bfan@briannaf OpenSource % git webkit pr --no-add ERROR: Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py:474: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 5 files style-checker failed, continue uploading pull request? Retry will amend the commit with your changes. (Yes/Retry/[No]): Retry Total errors found: 0 in 5 files Pushing to fork, which is classified as a public remote Verifying commits in 'default' mode Attempting to push 1 batch of commits to fork... Verified 1 novel commit to fork are safe to push Enumerating objects: 27, done. Counting objects: 100% (27/27), done. Delta compression using up to 10 threads Compressing objects: 100% (14/14), done. Writing objects: 100% (14/14), 3.68 KiB | 628.00 KiB/s, done. Total 14 (delta 13), reused 0 (delta 0), pack-reused 0 remote: Resolving deltas: 100% (13/13), completed with 13 local objects. To https://github.com/briannafan/WebKit.git + 8a7c18326d68...d747f78d14a6 eng/webkitbugspy-Implement-ability-to-relate-radars -> eng/webkitbugspy-Implement-ability-to-relate-radars (forced update) Updated 'PR 22306 | [webkitbugspy] Implement ability to relate radars'! https://github.com/WebKit/WebKit/pull/22306 `
Attachments
Add attachment proposed patch, testcase, etc.
Brianna Fan
Comment 1 2024-01-23 14:56:16 PST
(In reply to Brianna Fan from comment #0) > Inputting "retry" after the style checker finds issues in a commit will > result in no errors on command line, but when checking the commit on GitHub, > the fixes are not uploaded. > > For example, total errors become 0 after retry, but the whitespaces are > still present in the force-pushed commit. > ` > bfan@briannaf OpenSource % git webkit pr --no-add > ERROR: Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py:474: > trailing whitespace [pep8/W291] [5] > Total errors found: 1 in 5 files > style-checker failed, continue uploading pull request? > Retry will amend the commit with your changes. (Yes/Retry/[No]): Retry > Total errors found: 0 in 5 files > Pushing to fork, which is classified as a public remote > Verifying commits in 'default' mode > Attempting to push 1 batch of commits to fork... > Verified 1 novel commit to fork are safe to push > Enumerating objects: 27, done. > Counting objects: 100% (27/27), done. > Delta compression using up to 10 threads > Compressing objects: 100% (14/14), done. > Writing objects: 100% (14/14), 3.68 KiB | 628.00 KiB/s, done. > Total 14 (delta 13), reused 0 (delta 0), pack-reused 0 > remote: Resolving deltas: 100% (13/13), completed with 13 local objects. > To https://github.com/briannafan/WebKit.git > + 8a7c18326d68...d747f78d14a6 > eng/webkitbugspy-Implement-ability-to-relate-radars -> > eng/webkitbugspy-Implement-ability-to-relate-radars (forced update) > Updated 'PR 22306 | [webkitbugspy] Implement ability to relate radars'! > https://github.com/WebKit/WebKit/pull/22306 > ` Update: This did not reproduce on a different checkout...
Radar WebKit Bug Importer
Comment 2 2024-01-25 16:50:14 PST
<rdar://problem/121631481>
Note You need to log in before you can comment on or make changes to this bug.