RESOLVED FIXED267707
Make more service worker classes ref-counted 
https://bugs.webkit.org/show_bug.cgi?id=267707
Summary Make more service worker classes ref-counted
Chris Dumez
Reported 2024-01-18 09:38:20 PST
I recently did smart adoption of smart pointers in service worker code. In doing so I had to use CheckedPtr a lot because many of the classes were not ref-counted and I had no way to "protect" an object before calling a member function on it. It was then pointed out to me that we could make those classes ref-counted instead. I gave it a try and I think the code looks a lot safer. It is also a lot less likely to introduce new crashes (since it decreases the use of CheckedPtr).
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2024-01-18 09:40:25 PST
Pull request: https://github.com/WebKit/WebKit/pull/22919
EWS
Comment 2 2024-01-18 11:39:31 PST
Committed 273187@main (24bcf01c94b3): <https://commits.webkit.org/273187@main> Reviewed commits have been landed. Closing PR #22919 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-01-18 11:40:17 PST
<rdar://problem/121207803>
Note You need to log in before you can comment on or make changes to this bug.