Bug 267672 - First `make release` fails after deleting `WebKitBuild` directory
Summary: First `make release` fails after deleting `WebKitBuild` directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on: 266493
Blocks:
  Show dependency tree / graph
 
Reported: 2024-01-17 21:43 PST by Elliott Williams
Modified: 2024-01-17 22:39 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2024-01-17 21:43:52 PST 
rdar://121164032
Comment 1 Elliott Williams 2024-01-17 21:46:54 PST 
https://commits.webkit.org/273153@main changed a Makefile line from:

	XCODE_OPTIONS = `perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print XcodeOptionString()' -- $(BUILD_WEBKIT_OPTIONS)` $(ARGS)

to:

	XCODE_OPTIONS = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print XcodeOptionString()' -- $(BUILD_WEBKIT_BASE) 

I thought that the $(shell ) directive was lazy enough that it wouldn't get expanded until we had already done all needed setup. But it's getting expanded before the call to set-webkit-configuration, which may change the active workspace.
Comment 2 Elliott Williams 2024-01-17 21:53:46 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22895
Comment 3 EWS 2024-01-17 22:39:36 PST 
Committed 273165@main (f31c5c1ab031): <https://commits.webkit.org/273165@main>

Reviewed commits have been landed. Closing PR #22895 and removing active labels.