WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
267672
First `make release` fails after deleting `WebKitBuild` directory
https://bugs.webkit.org/show_bug.cgi?id=267672
Summary
First `make release` fails after deleting `WebKitBuild` directory
Elliott Williams
Reported
2024-01-17 21:43:52 PST
rdar://121164032
Attachments
Add attachment
proposed patch, testcase, etc.
Elliott Williams
Comment 1
2024-01-17 21:46:54 PST
https://commits.webkit.org/273153@main
changed a Makefile line from: XCODE_OPTIONS = `perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print XcodeOptionString()' -- $(BUILD_WEBKIT_OPTIONS)` $(ARGS) to: XCODE_OPTIONS = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print XcodeOptionString()' -- $(BUILD_WEBKIT_BASE) I thought that the $(shell ) directive was lazy enough that it wouldn't get expanded until we had already done all needed setup. But it's getting expanded before the call to set-webkit-configuration, which may change the active workspace.
Elliott Williams
Comment 2
2024-01-17 21:53:46 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22895
EWS
Comment 3
2024-01-17 22:39:36 PST
Committed
273165@main
(f31c5c1ab031): <
https://commits.webkit.org/273165@main
> Reviewed commits have been landed. Closing PR #22895 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug