WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
267645
Increase totalPixels of fast/forms/switch/no-pixels-outside-the-box.html and friend to encompass more platforms
https://bugs.webkit.org/show_bug.cgi?id=267645
Summary
Increase totalPixels of fast/forms/switch/no-pixels-outside-the-box.html and ...
Marta Darbinyan
Reported
2024-01-17 11:19:30 PST
Created
attachment 469432
[details]
diff image Description: fast/forms/switch/no-pixels-outside-the-box.html fast/forms/switch/no-pixels-outside-the-box-vertical-lr-rtl.html Are constant failure on macOS Ventura and Sonoma wk2 x86_64 and since the tests were added in
273089@main
This issue can be reproduced by using the command: run-webkit-tests --root --exit-after-n-failures 1 --debug fast/forms/switch/no-pixels-outside-the-box.html History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fforms%2Fswitch%2Fno-pixels-outside-the-box.html&test=fast%2Fforms%2Fswitch%2Fno-pixels-outside-the-box-vertical-lr-rtl.html&architecture=x86_64&version_name=Sonoma&version_name=Ventura&flavor=wk2
Image Diff: attached Link:
https://build.webkit.org/results/Apple-Sonoma-Release-WK2-Tests/273097@main%20(1340)/compositing/geometry/fixed-inside-overflow-scroll-diffs.html
Attachments
diff image
(3.48 KB, image/png)
2024-01-17 11:19 PST
,
Marta Darbinyan
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-01-17 11:27:38 PST
<
rdar://problem/121133972
>
Anne van Kesteren
Comment 2
2024-01-17 11:55:33 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22874
EWS
Comment 3
2024-01-17 14:26:39 PST
Committed
273145@main
(0f175b5f707c): <
https://commits.webkit.org/273145@main
> Reviewed commits have been landed. Closing PR #22874 and removing active labels.
Alexey Proskuryakov
Comment 4
2024-01-17 16:35:58 PST
The diff link above was for a different test. I think that this test has an actual failure, not noise to ignore.
https://build.webkit.org/results/Apple-Sonoma-Release-WK2-Tests/273117@main%20(1346)/fast/forms/switch/no-pixels-outside-the-box-diffs.html
Marta Darbinyan
Comment 5
2024-01-17 16:40:53 PST
Thanks for sharing the correct link here. I updated the radar with the link and thought it would update bugzilla automatically.
Anne van Kesteren
Comment 6
2024-01-17 23:52:32 PST
Alexey, see
https://github.com/WebKit/WebKit/pull/22703#issuecomment-1890437523
for why it's ignored. (And I used the correct test results to adjust the noise expectations.) I filed
bug 267679
to track the issue with painting outside the box.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug