Bug 26762 - clean up indentRegion
Summary: clean up indentRegion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-26 14:53 PDT by Ryosuke Niwa
Modified: 2009-07-20 16:22 PDT (History)
3 users (show)

See Also:

Attachments
cleans up indentRegion and isolates code dealing with list into a separate function (10.36 KB, patch)
2009-06-26 14:55 PDT, Ryosuke Niwa 		eric: review-
Details | Formatted Diff | Diff
cleans up indentRegion and adds some utility functions to htmlediting.h/cpp (45.76 KB, patch)
2009-06-26 18:25 PDT, Ryosuke Niwa 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2009-06-26 14:53:05 PDT 
In order to fix 21712, we need to clean up IndentOutdentCommand::indentRegion.
Comment 1 Ryosuke Niwa 2009-06-26 14:55:52 PDT 
Created attachment 31952 [details]
cleans up indentRegion and isolates code dealing with list into a separate function
Comment 2 Eric Seidel (no email) 2009-06-26 16:22:32 PDT 
Comment on attachment 31952 [details]
cleans up indentRegion and isolates code dealing with list into a separate function

Ryosuke and I sat and reviewed this in person.  r-. I look forward to your followup patch.
Comment 3 Ryosuke Niwa 2009-06-26 18:25:20 PDT 
Created attachment 31963 [details]
cleans up indentRegion and adds some utility functions to htmlediting.h/cpp
Comment 4 Eric Seidel (no email) 2009-06-26 19:15:19 PDT 
Comment on attachment 31963 [details]
cleans up indentRegion and adds some utility functions to htmlediting.h/cpp

Looks great.
Comment 5 Eric Seidel (no email) 2009-06-26 19:15:38 PDT 
Ryosuke and I went over this in person already too. :)
Comment 6 Eric Seidel (no email) 2009-06-26 19:15:52 PDT 
I'll land this later when I'm not walking away from the computer...
Comment 7 Brent Fulgham 2009-06-27 19:45:56 PDT 
Assigning for Landing.
Comment 8 Brent Fulgham 2009-06-27 20:14:28 PDT 
Landed in http://trac.webkit.org/changeset/45316.
Comment 9 Ryosuke Niwa 2009-07-13 16:10:20 PDT 
(In reply to comment #8)
> Landed in http://trac.webkit.org/changeset/45316.

Thank you for landing my patch.