WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
267617
fast/css/ios/update-user-interface-level.html fails if nothing triggers a style update on the root
https://bugs.webkit.org/show_bug.cgi?id=267617
Summary
fast/css/ios/update-user-interface-level.html fails if nothing triggers a sty...
Simon Fraser (smfr)
Reported
2024-01-16 20:54:59 PST
This PR [
https://github.com/WebKit/WebKit/pull/22531
] causes fast/css/ios/update-user-interface-level.html to fail. This test updates dark mode and "elevated user interface level" and checks to see if the base background color changed. baseBackgroundColor is updated in `LocalFrameView::updateBackgroundRecursively()` via: auto baseBackgroundColor = backgroundColor.value_or(RenderTheme::singleton().systemColor(cssValueControlBackground, view->styleColorOptions())); and in this case we're always calling `RenderTheme::singleton().systemColor(cssValueControlBackground()`. The problem is that the result of RenderTheme::singleton().systemColor() can change without a `styleDidChange` being triggered.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-01-23 20:55:14 PST
<
rdar://problem/121490021
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug