Bug 267605 - [run-webkit-tests] Expectation files errantly saved as a directory crash layout testing.
Summary: [run-webkit-tests] Expectation files errantly saved as a directory crash layo...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-16 14:13 PST by Ben Schwartz
Modified: 2024-01-16 14:13 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Schwartz 2024-01-16 14:13:23 PST 
As I [embarrassingly] discovered in 272938@main, if a directory exists with the same name as an expectation file in the location it would normally be, run-webkit-tests crashes when it tries to read it. I subsequently fixed the error in 272944@main.

It seems like this should be an easy fix -- just catching an error (this one was IsADirectoryError) when the expectations files are accessed.
Comment 1 Radar WebKit Bug Importer 2024-01-16 14:13:50 PST 
<rdar://problem/121076361>