.
<rdar://problem/121065998>
Created attachment 469419 [details] Patch
Comment on attachment 469419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=469419&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:4180 > + updatedObjects.set(axObject->objectID(), updatedFields); Not sure how expensive OptionSet copies are, but maybe WTFMove(updatedFields) would be more efficient? > Source/WebCore/accessibility/AXObjectCache.cpp:4188 > + updatedObjects.set(axObject->objectID(), updatedFields); WTFMove(updatedFields)? > Source/WebCore/accessibility/AXObjectCache.cpp:4196 > + updatedObjects.set(axObject->objectID(), updatedFields); WTFMove(updatedFields)?
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 469419 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=469419&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:4180 > > + updatedObjects.set(axObject->objectID(), updatedFields); > > Not sure how expensive OptionSet copies are, but maybe > WTFMove(updatedFields) would be more efficient? > > > Source/WebCore/accessibility/AXObjectCache.cpp:4188 > > + updatedObjects.set(axObject->objectID(), updatedFields); > > WTFMove(updatedFields)? > > > Source/WebCore/accessibility/AXObjectCache.cpp:4196 > > + updatedObjects.set(axObject->objectID(), updatedFields); > > WTFMove(updatedFields)? This OptionSet should be equivalent to an uint8_t, so I think it is not necessary to move.
Committed 273106@main (f890a7cc18de): <https://commits.webkit.org/273106@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469419 [details].