Bug 267538 - dump-class-layout prints class types with confusing indent
Summary: dump-class-layout prints class types with confusing indent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-15 05:08 PST by Kimmo Kinnunen
Modified: 2024-01-16 11:29 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2024-01-15 05:08:44 PST 
dump-class-layout prints class types with confusing indent

  +0 < 16> PaddingBetweenClassMembers
  +0 <  8>     BasicClassLayout basic1
  +0 <  4>       int intMember
  +4 <  1>       bool boolMember
  +5 <  3>   <PADDING: 3 bytes>
  +8 <  8>     BasicClassLayout basic2
  +8 <  4>       int intMember
 +12 <  1>       bool boolMember
 +13 <  3>   <PADDING: 3 bytes>


Should be

  +0 < 16> PaddingBetweenClassMembers
  +0 <  8>     BasicClassLayout basic1
  +0 <  4>         int intMember
  +4 <  1>         bool boolMember
  +5 <  3>     <PADDING: 3 bytes>
  +8 <  8>     BasicClassLayout basic2
  +8 <  4>         int intMember
 +12 <  1>         bool boolMember
 +13 <  3>     <PADDING: 3 bytes>
Comment 1 Radar WebKit Bug Importer 2024-01-15 05:08:55 PST 
<rdar://problem/121002860>
Comment 2 Kimmo Kinnunen 2024-01-15 05:26:11 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22780
Comment 3 EWS 2024-01-16 11:29:53 PST 
Committed 273083@main (f2a88a6e9512): <https://commits.webkit.org/273083@main>

Reviewed commits have been landed. Closing PR #22780 and removing active labels.