Bug 26753 – WebInspector: Fix typo in the resource panel enabler caption.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Change 'the this panel' to 'this panel'.

[Pavel Feldman]

Created attachment 31928 [details]
patch

[Timothy Hatcher]

Comment on attachment 31928 [details]
patch

Make sure to update the localizedStrings.js file.

[Pavel Feldman]

Created attachment 32000 [details]
patch with the fix

[Eric Seidel (no email)]

Unless Pavel has commit bit, this patch needs to be r-'d.

This patch does not have enough data to actually land it.  The git patch attached is missing the actual content of the binary file.

bugzilla-tool land-patches 26753 --no-build
Fetching: https://bugs.webkit.org/show_bug.cgi?id=26753&ctype=xml
Landing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Current branch ToLand is up to date.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1715  100  1715    0     0   3274      0 --:--:-- --:--:-- --:--:-- 1674k
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patch: **** Only garbage was found in the patch input.
patch -p0 "WebCore/English.lproj/localizedStrings.js" returned 2.  Pass --force to ignore patch failures.
Patch https://bugs.webkit.org/attachment.cgi?id=32000 failed to download and apply.

[Timothy Hatcher]

I see binary data in the patch.

[Eric Seidel (no email)]

Maybe the problem is that svn-apply just doesn't know how to handle these patches:

diff --git a/WebCore/English.lproj/localizedStrings.js b/WebCore/English.lproj/localizedStrings.js
index b85f91a91e5f88be8e7190e862bc615efe7487c5..f01d8a5e0266b361d11b4991f3aadcc8faf49a35 100644
GIT binary patch
delta 22
ecmaDfkMYtx#tk1lCRcfiOy==S+g#=Of)xOJZVC1P

delta 30
ocmV+(0O9}Ao&n;X0kH5$lVV96lbS{_linF3liWxYvtmi`1>Uv|q5uE@

I guess I'll have to teach svn-apply to be smarter.
I've filed https://bugs.webkit.org/show_bug.cgi?id=26830.  Until then, I guess we have to apply this diff by hand using git apply unless Pavel uploads a new copy made with svn-create-patch

[Pavel Feldman]

Created attachment 32045 [details]
svn patch

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
Committed r45516
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/English.lproj/localizedStrings.js
r45516 = 1085e473acffea3e17c6e7f9ef5d8e294ba45213 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/45516