Bug 267509 – Remove webkit-early-warning-system comments

• Status: NEW
• Component: Tools / Tests

[Anne van Kesteren]

In the normal flow of a GitHub issue or PR, a new comment results in a GitHub notification for everyone watching the issue, alerting them there is new information for them to act on.

The comments from webkit-early-warning-system violate this pattern. The comments are added almost immediately after you did something (e.g., created the PR or pushed to it) and there is nothing immediately actionable for anyone watching the PR to do. This makes WebKit/WebKit very noisy and not a reasonable repository to be watching (whereby you get notifications for every comment added), whereas I think it could be watchable if there were no comments from bots creating noise. I.e., when you'd only get notifications for new PRs or discussions on PRs by humans.

I would suggest that instead of having the bot comment we put the UI in the first comment of the PR ("OP"), where we already put the information for the latest commit(s). To reduce noise, we can put this behind nested details elements. Something like:

  > Build history

which when clicked would show

  \/ Build History

  > Details for ef90de5
  > Details for a26de00

and if you then click on one of these you would get the detailed table for that commit hash.

[Alexey Proskuryakov]

Getting the emails is pointless and annoying indeed, but I cannot tell for certain if this is how we can fix this, or something we considered and found worse than status quo.

[Anne van Kesteren]

That would be good to know of course before anything is done.

Note that not everyone uses email for GitHub notifications. At least with email there's a chance of filtering, but if you use the website only (as I do for a variety of reasons) that's not possible.

[Radar WebKit Bug Importer]

<rdar://problem/121332217>