WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
267481
Remove simple JS->Wasm entry thunks by using metadata
https://bugs.webkit.org/show_bug.cgi?id=267481
Summary
Remove simple JS->Wasm entry thunks by using metadata
Justin Michaud
Reported
2024-01-12 19:09:23 PST
Remove simple JS->Wasm entry thunks by using metadata
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-01-12 19:10:01 PST
<
rdar://problem/120933304
>
Justin Michaud
Comment 2
2024-01-12 19:11:17 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22739
Justin Michaud
Comment 3
2024-04-08 13:37:24 PDT
Closing old bugs assigned to me
Justin Michaud
Comment 4
2024-04-08 13:37:40 PDT
Closing old bugs assigned to me
Justin Michaud
Comment 5
2024-04-12 13:30:34 PDT
I clicked the wrong thing, this shouldn't have been closed
EWS
Comment 6
2024-04-16 12:11:48 PDT
Committed
277566@main
(4bd20953a44f): <
https://commits.webkit.org/277566@main
> Reviewed commits have been landed. Closing PR #22739 and removing active labels.
Diego Pino
Comment 7
2024-04-16 23:00:26 PDT
Debian 11 bot is failing after this change with the following error: /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/Source/JavaScriptCore/wasm/WasmCallee.h:255:11: error: expected nested-name-specifier before ‘enum’ 255 | using enum JSEntrypointInterpreterCalleeMetadata; | ^~~~ Debian 11 uses GCC10.2, which is currently the least GCC version supported [1] [2]. This version of the compiler doesn't support "using enum". [1]
https://github.com/webkit/webkit/blob/main/Source/cmake/WebKitCommon.cmake#L74
Diego Pino
Comment 8
2024-04-16 23:02:05 PDT
Re-opening for pull request
https://github.com/webkit/webkit/pull/27368
EWS
Comment 9
2024-04-17 01:00:34 PDT
Committed
277600@main
(fb54302c60a6): <
https://commits.webkit.org/277600@main
> Reviewed commits have been landed. Closing PR #27368 and removing active labels.
Justin Michaud
Comment 10
2024-04-19 13:10:29 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/27534
EWS
Comment 11
2024-04-19 15:01:43 PDT
Committed
277762@main
(4706d27c38ec): <
https://commits.webkit.org/277762@main
> Reviewed commits have been landed. Closing PR #27534 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug