WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
267417
[MSE][GStreamer] Dimension SourceBuffer size limit for all possible track types before init segment received
https://bugs.webkit.org/show_bug.cgi?id=267417
Summary
[MSE][GStreamer] Dimension SourceBuffer size limit for all possible track typ...
Enrique Ocaña
Reported
2024-01-11 09:51:48 PST
SourceBuffer has separate max size limits for video, audio and text, but it has to parse the init segment first to know if there are any video, audio or text tracks. At the very first appendBuffer() there are not tracks parsed yet, so platformMaximumBufferSize() returns 0 (as no tracks are there), and the limit is taken from MediaElementSession as audio limit 15MB as no video track is present. A potential buffer overflow at the very first appendBuffer() before tracks are parsed from init segment should be ignored. See:
https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1261
Attachments
Add attachment
proposed patch, testcase, etc.
Enrique Ocaña
Comment 1
2024-01-11 11:21:16 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22671
EWS
Comment 2
2024-01-15 06:19:27 PST
Committed
273039@main
(71e98e404115): <
https://commits.webkit.org/273039@main
> Reviewed commits have been landed. Closing PR #22671 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-01-15 06:20:14 PST
<
rdar://problem/121004491
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug