Bug 267355 - REGRESSION(272844@main): [ wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html is consistently failing.
Summary: REGRESSION(272844@main): [ wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-10 11:45 PST by Ben Schwartz
Modified: 2024-01-12 13:24 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Schwartz 2024-01-10 11:45:22 PST 
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html

This test, previously consistently failing on all platforms except macOS arm64, has now further regressed to failing on macOS arm64.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc%2FRTCPeerConnection-GC.https.html

TEXT DIFF:

-PASS GC does not collect a peer connection pipe rendering to a video element
+FAIL GC does not collect a peer connection pipe rendering to a video element promise_test: Unhandled rejection with value: object "Error: Timeout waiting for video size change"
 
DIFF URL:

https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/272844@main%20(13035)/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https-pretty-diff.html

REPRODUCIBILITY:

I was able to reproduce this issue on macOS Sonoma (14.2, 23C71/arm64) ToT using the following commands:

python3 Tools/CISupport/download-built-product --platform=mac --release 'https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-sonoma-x86_64 arm64-release/272844@main.zip'
python3 Tools/CISupport/built-product-archive --platform=mac-sonoma --release extract
python3 Tools/Scripts/run-webkit-tests --no-build -v --release --results-directory WebKitBuild/layout-test-results --debug-rwt-logging imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html --iterations 10

REGRESSION:

I was able to identify a potential regression point at 272844@main. This specific issue did not reproduce before then, and changes at that point seem to be indirectly related to the issue.
Comment 1 Radar WebKit Bug Importer 2024-01-10 11:45:53 PST 
<rdar://problem/120798707>
Comment 2 EWS 2024-01-10 12:18:25 PST 
Test gardening commit 272856@main (553133d69b74): <https://commits.webkit.org/272856@main>

Reviewed commits have been landed. Closing PR #22607 and removing active labels.
Comment 3 youenn fablet 2024-01-11 08:11:48 PST 
Will take a look tomorrow.
Comment 4 youenn fablet 2024-01-12 03:26:35 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22704
Comment 5 youenn fablet 2024-01-12 03:34:51 PST 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/43966
Comment 6 EWS 2024-01-12 13:24:30 PST 
Committed 272990@main (87194aeb6d38): <https://commits.webkit.org/272990@main>

Reviewed commits have been landed. Closing PR #22704 and removing active labels.