Bug 26733 - Add V8 methods to notify clients about context creation/destruction
Summary: Add V8 methods to notify clients about context creation/destruction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-25 14:41 PDT by Matt Perry
Modified: 2009-06-25 16:21 PDT (History)
0 users

See Also:


Attachments
adds 2 methods to FrameLoaderClient.h (1.46 KB, patch)
2009-06-25 14:44 PDT, Matt Perry
fishd: review-
Details | Formatted Diff | Diff
made pure virtual (2.21 KB, patch)
2009-06-25 16:12 PDT, Matt Perry
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Perry 2009-06-25 14:41:27 PDT
Add V8-only methods to FrameLoaderClient that V8 can use to send out notifications when it creates/destroys a script context.
Comment 1 Matt Perry 2009-06-25 14:44:09 PDT
Created attachment 31877 [details]
adds 2 methods to FrameLoaderClient.h
Comment 2 Darin Fisher (:fishd, Google) 2009-06-25 15:58:21 PDT
Comment on attachment 31877 [details]
adds 2 methods to FrameLoaderClient.h

> Index: WebCore/ChangeLog
...
> +        Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=26733
> +
> +	Add V8-only methods to FrameLoaderClient that V8 can use to send
> +	out notifications when it creates/destroys a script context.

Replace tabs with spaces


> Index: WebCore/loader/FrameLoaderClient.h
...
> +#if USE(V8)
> +        virtual void didCreateScriptContext() const { }
> +        virtual void didDestroyScriptContext() const { }

I think these should be pure virtual like the other FrameLoaderClient methods.

Otherwise, LG
Comment 3 Matt Perry 2009-06-25 16:12:03 PDT
Created attachment 31884 [details]
made pure virtual
Comment 4 Darin Fisher (:fishd, Google) 2009-06-25 16:21:50 PDT
Landed as http://trac.webkit.org/changeset/45208