Bug 26733 – Add V8 methods to notify clients about context creation/destruction

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Matt Perry]

Add V8-only methods to FrameLoaderClient that V8 can use to send out notifications when it creates/destroys a script context.

[Matt Perry]

Created attachment 31877 [details]
adds 2 methods to FrameLoaderClient.h

[Darin Fisher (:fishd, Google)]

Comment on attachment 31877 [details]
adds 2 methods to FrameLoaderClient.h

> Index: WebCore/ChangeLog
...
> +        Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=26733
> +
> +	Add V8-only methods to FrameLoaderClient that V8 can use to send
> +	out notifications when it creates/destroys a script context.

Replace tabs with spaces


> Index: WebCore/loader/FrameLoaderClient.h
...
> +#if USE(V8)
> +        virtual void didCreateScriptContext() const { }
> +        virtual void didDestroyScriptContext() const { }

I think these should be pure virtual like the other FrameLoaderClient methods.

Otherwise, LG

[Matt Perry]

Created attachment 31884 [details]
made pure virtual

[Darin Fisher (:fishd, Google)]

Landed as http://trac.webkit.org/changeset/45208