Bug 26729 - svn-apply (and svn-create-patch) shouldn't overwrite binary files with changes since the patch
Summary: svn-apply (and svn-create-patch) shouldn't overwrite binary files with change...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-25 14:13 PDT by David Levin
Modified: 2023-10-29 06:53 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-06-25 14:13:24 PDT 
When I applied https://bugs.webkit.org/attachment.cgi?id=31699 to my tree, the patch for WebCore/English.lproj/localizedStrings.js happily applied to my tree even though the applying the patch incorrectly undid changes.

Ideally, svn-apply would fail in this case so that the user would notice the issue.  In my case, I was fortunately to catch the issue before checking in, but I could have easily missed in (and in a more automated handling of the bug, this would definitely have been missed at present).
Comment 1 Ahmad Saleem 2023-10-29 06:53:29 PDT 
Jon & Ryan - is this still needed since now our workflow is heavily 'Git' based?