Bug 267210 - Remove unused 'CStringTranslator' in StringImpl.h
Summary: Remove unused 'CStringTranslator' in StringImpl.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-07 11:44 PST by Ahmad Saleem
Modified: 2024-01-08 01:55 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2024-01-07 11:44:10 PST 
Hi Team,

While looking into 'StringImpl.h', it seems we have following two references in code:

https://searchfox.org/wubkat/rev/88bdb08baf23b66d0495fe895e251cc5fb8c40e6/Source/WTF/wtf/text/StringImpl.h#189

and

https://searchfox.org/wubkat/rev/88bdb08baf23b66d0495fe895e251cc5fb8c40e6/Source/WTF/wtf/text/StringImpl.h#69

Looking into it, we don't have any other references to it.

So I think we can safely remove these unless if there are any internal use cases etc.

Thanks!
Comment 1 EWS 2024-01-08 01:54:03 PST 
Committed 272755@main (3db3a794a844): <https://commits.webkit.org/272755@main>

Reviewed commits have been landed. Closing PR #22496 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2024-01-08 01:55:14 PST 
<rdar://problem/120634868>