Bug 267205 – Fix warnings found by compiling with -Wfinal-dtor-non-final-class

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[David Kilzer (:ddkilzer)]

Fix warnings found by compiling with -Wfinal-dtor-non-final-class


Example:


Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:64:19: error: class with destructor marked 'final' cannot be inherited from [-Werror,-Wfinal-dtor-non-final-class]
   59 | class Connection : public CanMakeWeakPtr<Connection>, public IPC::MessageSender {
      |                  final
   60 |     WTF_MAKE_FAST_ALLOCATED;
   61 | public:
   62 |     static std::unique_ptr<Connection> create(std::optional<Action>, PreferTestService, Reconnect);
   63 |     Connection(std::optional<Action>, PreferTestService, Reconnect);
   64 |     ~Connection() final { }
      |                   ^
Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:59:7: note: mark 'WebPushTool::Connection' as 'final' to silence this warning
   59 | class Connection : public CanMakeWeakPtr<Connection>, public IPC::MessageSender {
      |       ^
1 error generated.

[Radar WebKit Bug Importer]

<rdar://problem/120609974>

[David Kilzer (:ddkilzer)]

Pull request: https://github.com/WebKit/WebKit/pull/22487

[EWS]

Committed 272769@main (5381539f603f): <https://commits.webkit.org/272769@main>

Reviewed commits have been landed. Closing PR #22487 and removing active labels.