Bug 267196 - Fix warnings found by compiling with -Wmisleading-indentation
Summary: Fix warnings found by compiling with -Wmisleading-indentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 126724 219688
Blocks: 267387
  Show dependency tree / graph
 
Reported: 2024-01-06 21:25 PST by David Kilzer (:ddkilzer)
Modified: 2024-01-10 17:53 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2024-01-06 21:25:14 PST 
Fix warnings found by compiling with -Wmisleading-indentation.


Examples:


WebKitBuild/Release/DerivedSources/WebCore/Settings.cpp:3320:9: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
 3320 |         m_values.authorAndUserStylesEnabledInspectorOverride = authorAndUserStylesEnabledInspectorOverride;
      |         ^
WebKitBuild/Release/DerivedSources/WebCore/Settings.cpp:3318:5: note: previous statement is here
 3318 |     if (m_values.authorAndUserStylesEnabledInspectorOverride == authorAndUserStylesEnabledInspectorOverride)
      |     ^


Source/WebCore/platform/ios/wak/WKView.mm:232:17: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
  232 |                 break;
      |                 ^
Source/WebCore/platform/ios/wak/WKView.mm:230:13: note: previous statement is here
  230 |             if (widthOrHeight < 0.0f)
      |             ^
Comment 1 Radar WebKit Bug Importer 2024-01-06 21:25:34 PST 
<rdar://problem/120600518>
Comment 2 David Kilzer (:ddkilzer) 2024-01-06 21:27:39 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22480
Comment 3 EWS 2024-01-08 09:31:08 PST 
Committed 272772@main (27103d255680): <https://commits.webkit.org/272772@main>

Reviewed commits have been landed. Closing PR #22480 and removing active labels.